Daniel Ziegenberg

[BUGFIX] Fix comment parsing to support multiple comments

5

Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by...

[FEATURE] Add consumeWhitespaceWithComments and redirect consumeWhitespace (backported)

4

Having `consumeWhitespace` also consumes comments, and returning them was unexpected. This also "deprecates" the consumeWhitespace method and announces a breaking change for 9.0.0.

Fix removed /cache/classes/loaders.php, resolves #708

1

Also, `cache_application` was renamed to `application_cache`.

This branch fixes the dynamic property warnings listed in #836.

Running the checks I get: ``` PHP Deprecated: Creation of dynamic property auth_saml2\check\certificateexpiry::$id is deprecated in /web/auth/saml2/classes/check/certificateexpiry.php on line 46 PHP Deprecated: Creation of dynamic property auth_saml2\check\certificateexpiry::$name is deprecated in...

That might be helpful when testing through a reverse proxy, which does SSL termination.