ziad hany

Results 131 comments of ziad hany

All these vulnerabilities don't have any related packages and it is old and not open source like you said @pombredanne [ignore.txt](https://github.com/nexB/vulnerablecode/files/11655066/ignore.txt)

> @ziadhany LGTM! please add some unit tests for same Done , @TG1999 have a look at the tests and Lmk if I need to add more tests

@pombredanne @TG1999 can you suggest a way to improve the performance ?

> @ziadhany For a data dump type of export, I would suggest simplifying the data structure by handling each model separately. Trying to load all relationships at once is likely...

Using prefetching makes performance worse. Maybe I'm using it in the wrong way. there is a lot of query duplication and just 10 loops take more than `2129.20 ms `...

> @ziadhany what's pending on this ? yes, this PR is ready to be merged.

> @ziadhany please see, tests are failing @TG1999 Done! Could you please review and approve so we can merge?

I think I got a really interesting result, take a look at https://www.kaggle.com/code/ziadhany/decision-trees-for-converting-cvss-2-to-3

I think this issue is interesting, and I'll assign it to myself, if no one working on it > @TG1999 @pombredanne I think we are ready to assign this one...