Boardwalk icon indicating copy to clipboard operation
Boardwalk copied to clipboard

Nougat ZipException

Open AlexDicy opened this issue 7 years ago • 56 comments

S7 edge, Nougat 7.0 Screenshot As seen in #302

@zhuowei, I'd like to work with you on the project, is it possible?

AlexDicy avatar Apr 13 '17 14:04 AlexDicy

I think that no. This is closed source. Same issue here but it is related to the new storage framework used in Android N. This app is not yet upgraded to that API.

minealex2244 avatar Apr 14 '17 13:04 minealex2244

Well, I asked Zhuowei ahah

AlexDicy avatar Apr 14 '17 14:04 AlexDicy

Can you tell me the coding languages you know? I'm planning to decompile the app and to see what I can do to test it (unfortunately it will be just for myself as it is illegal to redistribute this app but I'll see what I can do).

minealex2244 avatar Apr 14 '17 14:04 minealex2244

I decompiled it an hour ago but I found some lib (.so file) which I only seen with the hex editor, it's 6KB and doesn't seem to be part of the execution

Anyway I know Java, PHP, HTML, JS, CSS, SQL and maybe something else (which I can't remember right now)

AlexDicy avatar Apr 14 '17 14:04 AlexDicy

That's cool. :D I think there isn't anything important in the .so files but there is something in the Storage access classes. Google made some modifications to the Storage Access Framework which is just a pain for Devs. I will try to see if there is any workaround.

minealex2244 avatar Apr 14 '17 14:04 minealex2244

Alright, I'll see too, let me setup the project

AlexDicy avatar Apr 14 '17 14:04 AlexDicy

Here is the logcat I've taken: ---- 14 apr. 2017 18:28:31 ----

04-14 18:26:29.399 4112 4760 I System.out: Dex pack: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/dex_pack/1.9.jar

04-14 18:26:29.406 4112 4760 I System.out: Dex pack: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/dex_pack/1.9.jar

04-14 18:26:30.291 4112 4760 I System.out: Dex pack: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/dex_pack/1.9.jar

04-14 18:26:30.297 4112 4760 I System.out: Renaming: /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/versions/1.9/1.9.jar to /data/user/0/net.zhuoweizhang.boardwalk/app_working_dir/tmp/1.9.jar1267705696.jar

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.util.IoUtil.pipe(IoUtil.java:33)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.util.CleanZipUtil.shardZip(CleanZipUtil.java:124)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.downloader.MinecraftLaunch.createDexPack(MinecraftLaunch.java:64)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.LaunchMinecraftTask.downloadMinecraft(LaunchMinecraftTask.java:127)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.LaunchMinecraftTask.doInBackground(LaunchMinecraftTask.java:47)

04-14 18:27:16.349 4112 4760 W System.err: at net.zhuoweizhang.boardwalk.LaunchMinecraftTask.doInBackground(LaunchMinecraftTask.java:15)

---- 14 apr. 2017 18:28:31 ----

minealex2244 avatar Apr 14 '17 15:04 minealex2244

ok thanks for the logcat let me see what's in the Java file

AlexDicy avatar Apr 14 '17 15:04 AlexDicy

And that's just one error, I don't really know what's happening, maybe you used another decompiler, do you mind sharing the src? screen

AlexDicy avatar Apr 14 '17 16:04 AlexDicy

Which tool did you used to decompile the apk file? A JadX based one? I ask this because I like the way the app was decompiled.

minealex2244 avatar Apr 14 '17 18:04 minealex2244

@minealex2244 I used dex2jar for the jar and jd-gui for the .java files But what are you talking about, the colors?

AlexDicy avatar Apr 14 '17 18:04 AlexDicy

I know a lot of tools​ to decompile apks but I see that your apk was decompiled very good. I don't mean the IDE but it is cool too. Now that I have some free time I'll try to decompile it to see what's inside.

minealex2244 avatar Apr 14 '17 18:04 minealex2244

Same as #299

juliuscaesar1597 avatar Apr 19 '17 17:04 juliuscaesar1597

How has the app decompiled for you guys? I've written in java for a long time and I've had the idea to decompile it and see if I can fix it (it should be simple), but I'm not sure if it'll even decompile correctly.

EmotionalLove avatar Jan 17 '18 18:01 EmotionalLove

@2F4Uof2b2t Decompilers won't give recompilable code. Disassemblers may work, but please don't.

zhuowei avatar Jan 17 '18 20:01 zhuowei

@zhuowei you should provide a way to fix these issues. The app is unusable right now.

AlexDicy avatar Jan 17 '18 20:01 AlexDicy

I know, and I have plans for a rewrite.

zhuowei avatar Jan 17 '18 20:01 zhuowei

@zhuowei ok, thank you.

AlexDicy avatar Jan 17 '18 20:01 AlexDicy

@khanhduytran0 Could you please release instructions in how to do this? Or even better Upload the APK?

lerepex avatar Sep 22 '18 20:09 lerepex

@khanhduytran0 could you elaborate, any help would be great as I've been at this for over a year ;-;

gingerbryn1 avatar Oct 05 '18 16:10 gingerbryn1

@khanhduytran0 This doesn't look like Boardwalk 1.9 - it's using the regular Android ART runtime, not Boardwalk 1.9's (failed) attempt to use a different runtime. Also, pretty sure distributing Minecraft JARs pre-dexed in the APK breaks the Minecraft license.

Why gl4es instead of glShim? Does it work better? I might switch to it for Boardwalk 2.

Edit: ... ok gl4es isn't used anywhere. Why is it included then?

I haven't tried this: how well does it run on newer phones?

Edit: why does this rip out Boardwalk's Minecraft login code? Minecraft still uses the same authentication system.

Edit: I see a button for "Mods manager (Forge)" in your app, but I don't think it works? Your app doesn't convert files from Java to Android dex at all, so no mods would/could ever load. Adding mod support in Boardwalk would require a rewrite (which is why 2.0 is taking so long); I'll be interested to see how you would get it working.

I should probably yell at you for using Boardwalk code without permission, (and I will need to ask you to take this down eventually), but for now, good work.

zhuowei avatar Oct 06 '18 05:10 zhuowei

It is working pretty well on newer devices. I have a Samsung Galaxy S9 and I'm getting 30+ fps. Sometimes I'm getting 60 fps with just view bobbing enabled and with chunks rendering set to 5. Water is causing lag because of the animation. Optifine would fix everything. Good work @khanhduytran0 👍🏻

minealex2244 avatar Oct 06 '18 11:10 minealex2244

@khanhduytran0 have you already taken down the repository ;-;

gingerbryn1 avatar Oct 07 '18 02:10 gingerbryn1

@khanhduytran0 I have used 1.7.10. I'm not sure about Optifine API. I'll search for it. Edit: It looks like Optifine is just a patched Minecraft jar file.

minealex2244 avatar Oct 07 '18 05:10 minealex2244

@khanhduytran0 where is the download for your app? I would love to try it on my galaxy s9

Letfordlay avatar Oct 07 '18 14:10 Letfordlay

@khanhduytran0 this is impressive

gingerbryn1 avatar Oct 09 '18 04:10 gingerbryn1

It works.... it runs minecraft just as well as my 4gb computer XD....(using this on galaxy s9)

XxSp0oky777xX avatar Oct 09 '18 19:10 XxSp0oky777xX

@khanhduytran0 It runs very well on my galaxy s9, very impressive!

Letfordlay avatar Oct 09 '18 20:10 Letfordlay

@khanhduytran0 could you publish the sources?

sgdc3 avatar Oct 09 '18 23:10 sgdc3

@zhuowei I feel like if you made Boardwalk an open source project that it would be more successful if the community could contribute to the project with pull requests. For example @khanhduytran0 got it running on Android 7 and up and it runs very smooth (60fps on my GS9)

You should seriously considering publishing the sources under an open source license like the GPL3 and accepting pr's.

EmotionalLove avatar Oct 31 '18 01:10 EmotionalLove