Min Zhu

Results 48 comments of Min Zhu

fyi - same issue also exist in hermetic-build library-generation-unit-test, context: https://github.com/googleapis/sdk-platform-java/pull/3550

@JoeWang1127 Do you think this makes sense while we figure out a better way to only disable for 1.2.x? So we don't get upgrades like https://github.com/googleapis/sdk-platform-java/pull/3704

error message: ``` Error: Failures: Error: BomContentTest.testLtsBom:62->checkBom:81->assertUniqueClasses:154 Failing test due to duplicate classes found on classpath: Duplicate class META-INF.versions.9.module-info found in classpath. Found in artifacts com.google.errorprone:error_prone_annotations:2.26.1 and com.google.j2objc:j2objc-annotations:3.0.0. Duplicate class...

error in ci/lint and ci/showcase, ``` Error: Failed to execute goal com.coveo:fmt-maven-plugin:2.13:check (default-cli) on project gapic-generator-java: Execution default-cli of goal com.coveo:fmt-maven-plugin:2.13:check failed: An API incompatibility was encountered while executing com.coveo:fmt-maven-plugin:2.13:check:...

> @zhumin8 is there a reason for this update, i.e., security vunlnerability? No security vulnerabilities. Mostly trying to be consistent with our documentation discussion (see internal [comment](https://docs.google.com/document/d/1g8HJCstkEEZZc73gFlQO8uPGs07SkWKkr7NG-Yg4bvM/edit?disco=AAABfhkEpJM))

also: https://github.com/googleapis/sdk-platform-java/pull/3481, https://github.com/googleapis/sdk-platform-java/pull/3542

later runs of sonar workflow has no issue: https://github.com/googleapis/sdk-platform-java/actions/runs/11823259150 Maybe flaky?

I think these sonar failures may not be flaky, but rather as @jinseopkim0 pointed out is related to access setup. Observed that all renovate bot PRs fail on 401, also...

Thanks for reporting. We will look into and have it fixed.