Zhuojie Zhou

Results 50 comments of Zhuojie Zhou

What are your current OAuth or SSO solution in your company? Is it possible that you implement your own login page with any ID providers you have, and just store...

Definitely open to it. We have HS256 and RS256 now, and it should be straightforward to add more JWT validations. https://github.com/checkr/flagr/blob/master/pkg/config/middleware.go#L122-L132

Thanks, this is awesome! I will take a look soon

This is great idea, and I think it's domain-specific and better be done by the application itself instead of Flagr. Flagr is entity agnostic, and that's why entity context is...

Thinking of the API design, there are many options (see below), and `/` in the flagKey can cause some confusion in the URL, wondering if URL encoded string is needed...

> > add your own utility function > > I'm not opposed to this idea necessarily, but it does require more processing overhead on both the client side and server...

I actually like that we keep the unique index including deleted flags, this makes restoring the deleted flags logic simple and clean in the future. Is it possible to create...

Got it, I was thinking of syncing flags recently and added features like exporting the eval cache to JSON files. For example, we are using the exported JSON files in...

We can also try YAML as the serialization format, definitely open to contribution.

Sounds good! I think we can systematically handle the response size problem, especially for batch evaluation. A few things to note: - Make sure the entity context is still logged...