Wu Zhong comments

Results 70 comments of


                                            Wu Zhong

【iOS】Fixes ellipsis carries background from trimmed text

any one can help to review? cc. @sammy-SC @javache

【iOS】Fixes ellipsis carries background from trimmed text

@javache Done :)

【iOS】Fixes ellipsis carries background from trimmed text

@cipolleschi Hi, I just keep the same color related attributes as the character that precedes it. Other attributes like fontSize would impact the layout of the text.

【iOS】Fixes ellipsis carries background from trimmed text

@javache done 😀

[iOS] Fixes the exported synchronous method not being called on the method queue when it's the main queue

> I don't think this is desirable to do automatically. > > Any method marked as sync should be invoked synchronously from the JS thread. If a module requires this...

[iOS] Fixes the exported synchronous method not being called on the method queue when it's the main queue

@javache Hi, as you said, we need to fix the issue in the modules like `Appearance` right? If so, I can change my PR to fix those modules issues.

[iOS] Fixes the exported synchronous method not being called on the method queue when it's the main queue

@javache Done. Please review again.

[iOS] Fabric: Fixes Modal present splash when animation type is none

@dmytrorykun Hi, friendly ping, any progress on reviewing this PR?

[iOS] Fabric: Fixes Modal present splash when animation type is none

Merge main branch to fix the conflict.

[iOS] Fabric: Fixes Modal present splash when animation type is none

@cipolleschi Hi, any chance to keep forward this PR? :)