Zhongshi Xi
Zhongshi Xi
@hhhjort yes, sorry for the late rely, i am slowing working on this, you can expect next week i will update the commit
going to resume the work today
> For future reference, can you not force push as it squashes the commits from the past making it harder to review. Thank you! @AlexBVolcy thanks for pointing it out,...
> @zhongshixi Hey! Just checking in on the status of this PR? I want to be clear that the code coverage comments that I left aren't critical to be implemented...
still working on it
@AlexBVolcy have added some unit test according to your requests, let me know if they look good
cc @bsardo
> glog.Infof("[PubstackModule] Shutdown") @guscarreon i have updated the PR with your suggestion, take a look
> @zhongshixi sorry I'm coming in a bit late here. I was about to merge this but I noticed that we are introducing another logging library `clog`. Why do we...
@bretg here you go