Zhitao Li

Potential bug: lost export_ops->unexport() if export_ops->lookup_path() fails

2

In our environment, I find that fsal_export->unexport() is never called, which fsal_export->release() is called. The following log shows that lookup_path() fails and unexport() is skipped because of no root object....

The call of test_access() in readdir_cbk maybe unnecessary

2

The call of test_access() always returns OK if `access_mask_attr` is 0, which may degrade performance if it falls into underlying FSAL. ``` if (attribute_is_set(tracker->req_attr, FATTR4_ACL)) access_mask_attr |= FSAL_ACE4_MASK_SET(FSAL_ACE_PERM_READ_ACL); /* Attrs...

Must ping timeout be in seconds?

1

https://github.com/kolapapa/surge-ping/blob/1b918ff301565a36cfc5fdf09a503b7409ba4274/src/ping.rs#L58 I think it supports milliseconds also according to the implementation. Just make sure my understanding is right.

Where should we support set-group-ID bit(S_ISGID) on the directory in nfs-ganesha?

4

In our current implementation of FSAL, set-group-ID feature is not supported in our test. And it does work in nfs-ganesha with VFS fsal. For those who may not be aware...

Does FSAL fsal_staticfsinfo_t.maxpathlen work?

2

It seems this field is not read by NFS clients. In our case, we set the value as 1024. However, invalid symlink request with linkpath larger than this is not...

As can be seen from the declaration of the class `Family`, there is only one method named `Remove()`, which can remove the metric added before. https://github.com/jupp0r/prometheus-cpp/blob/6492e820cdff7e7345d46d82b43735aaea542098/core/include/prometheus/family.h#L62 We worry about that...