BiMPM icon indicating copy to clipboard operation
BiMPM copied to clipboard

BiMPM implementation in AllenNLP

Open handsomezebra opened this issue 5 years ago • 1 comments

@zhiguowang Thanks a lot for publishing the algorithm and code of BiMPM. I am implementing the BiMPM algorithm in the AllenNLP library so that more people could experiment and benefit from this algorithm. Please check the PR https://github.com/allenai/allennlp/pull/1594 for the re-implementation. It is based on your paper as well as the code here, and also can reproduce most of the results you described in the paper. Please help to review the code and let me know if you have any comments and suggestions about the PR. Thanks!

handsomezebra avatar Aug 09 '18 18:08 handsomezebra

Hi Handsome,

Thanks very much for you hard work. I'm very glad to help you to review the code. However, I will be very busy in the following weeks. I will definitely review the code when I'm free.

Best, Zhiguo

On Thu, Aug 9, 2018 at 2:34 PM, Handsome Zebra [email protected] wrote:

@zhiguowang https://github.com/zhiguowang Thanks a lot for publishing the algorithm and code of BiMPM. I am implementing the BiMPM algorithm in the AllenNLP library so that more people could experiment and benefit from this algorithm. Please check the PR allenai/allennlp#1594 https://github.com/allenai/allennlp/pull/1594 for the re-implementation. It is based on your paper as well as the code here, and also can reproduce most of the results you described in the paper. Please help to review the code and let me know if you have any comments and suggestions about the PR. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zhiguowang/BiMPM/issues/48, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEV-V1fpD2IVdRsOBWEgdxb7oiEJmfNks5uPICpgaJpZM4V2Mut .

zhiguowang avatar Aug 10 '18 13:08 zhiguowang