Maxim Zhiburt

Results 278 comments of Maxim Zhiburt

But 25 already turns this off. https://github.com/r-lib/cli/blob/fe7c8acdb203e9ccfae9a8450641ab02c4a4f6be/src/ansi.c#L241-L243 Where I need to put tests?

Maybe add support for `26` and `50` also make sense but I would do it in a different PR.

> Right, sorry, but they use the same binary state, i.e. 6 is also slow blink now, not fast blink. I suppose that is not intentional. That's intentional as they...

Also might be related as I also get on one test ``` thread 'python' panicked at 'assertion failed: `(left == right)` left: `4`, right: `0`', /home/mzhiburt/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-lite-1.12.0/src/io.rs:1700:13 ```

And ongoing question, if you don't mind. Is it safe to do the following. ``` future::poll_once(self.inner.read(buf)).await ``` Where inner is a `BufRead`; Because it just don't work, the buffer is...

Testing it in a different project and `read_line` works fine. ...

I can state that it sometimes fails and sometimes not. ```rust p.read_line(&mut msg).await.unwrap(); // works *** p.read_line(&mut msg).await.unwrap(); // panic on assert_debug ```

So moving from `async-fs` to `async-io` cause a different issue on the same code ``` thread 'python' panicked at 'assertion failed: buf.is_empty()', /home/mzhiburt/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-lite-1.12.0/src/io.rs:1699:13 ```

Running it in `--release` to disable debug_asserts drops 6 characters where were available if we would read it in a sync mode.

Hey @vmi I've review your changes it's seems to work :+1: I would only mention in a doc comment for `replaceVars` that it prioritize selenium vars after js vars if...