MegaDepth icon indicating copy to clipboard operation
MegaDepth copied to clipboard

Loss functions

Open alexgkendall opened this issue 6 years ago • 1 comments

Awesome work, this is a fantastic concept. I had a question about the loss:

https://github.com/lixx2938/MegaDepth/blob/f1ffe4ca8b6c49e55e36259ac34909de6c90a27b/models/HG_model.py#L116

Why do you have a square root term here, this doesn't correspond to Eq. 2 in the paper? For the hyperparams you supply in the paper are they with this sqrt loss or the one from your paper?

It would also be great to see implementations of the gradient loss term too if you can.

Thanks!

alexgkendall avatar Oct 19 '18 07:10 alexgkendall

I also want to see the implementations of the three loss in paper...

zhangxgu avatar Dec 05 '18 09:12 zhangxgu