zhao, zhenhui

> Thank you for the update. Re: timestamp - do you have access to a debugger? Can you use it to debug this issue? Yes I use gdb to debug...

> @zhejiangxiaomai For timestamp, just add this code to velox/exec/tests/utils/QueryAssertions.cpp > > ``` > template > velox::variant variantAt(const ::duckdb::Value& value) { > return velox::variant::timestamp( > duckdbTimestampToVelox(value.GetValue())); > } > ```...

Hi @mbasmanova would review again. I added timestamp test just now.

Hi, @mbasmanova all comments fixed. Would review it again？ Merry Christmas to you in advance.

> Hi @zhejiangxiaomai , Feel free to pull from latest and address open comments if still interested . Thanks ! Thank you for reminding me. I am fixing some comments...

Hi @mbasmanova, I passed the UT for nested struct. Would you review this PR again? It's been a long time. The main idea of this PR is that use nested...

Hi @mbasmanova all comments are fixed. Would you please review my minor fix at https://github.com/facebookincubator/velox/pull/2451/commits/43870cc879c7961ba11474ba52bd2f54819fedcf when you are free?

Hi, @mbasmanova. I just fixed all comments. The main change is that I introduce currentInputType to record the right RowType for toSubstraitExpr. For expression like (abc).ab.a in function [toSubstraitExpr](https://github.com/facebookincubator/velox/pull/2451/files?diff=split&w=1#diff-65defa30896670ec464dc213f57cf6a8066b5022cf6b862ccc33c332b4a25120R455), the...

Hi, @mbasmanova sorry for late reply. I read your comments carefully today, and fix all comments now. It's been too long so I'll summarize the changes. At "velox-to-substrait" side. There...

Hi, @mbasmanova do you have any suggestions? just want to remind you gently.