Results 61 comments of zhao, zhenhui

> @zhejiangxiaomai You are correct. I have protoc version 3.19.4. > > ``` > % protoc --version > libprotoc 3.19.4 > ``` > > > I recommand that we should...

Hi, @mbasmanova, round-trip tests are added, Could you please review this PR again? Thank you.

Hi @mbasmanova, I fix json error which is detect by substrait validator. can you take a look, and merge this PR. Here is result of q6_first_stage.json. ![image](https://user-images.githubusercontent.com/14065538/190562082-6906ce5d-2052-4376-87f1-b25265540742.png)

Here is the substrait-validator result of q1_first_stage.json. ![image](https://user-images.githubusercontent.com/14065538/190630940-2c457238-37f5-40ef-811e-4b07ad76d870.png)

Hi, @kgpai @mbasmanova all UT passed. And I make sure that centos in circleCI can work now. Could you please review this PR again? And merge it.

> @zhejiangxiaomai Sorry for the late review. You are welcome, thank you very much for your time.

> @zhejiangxiaomai How long do Subtrait tests run? We can consider adding them to linux-parquet-hive-storage-adapters-build run. We can rename this to simply `linux-adapters`. Subtrait tests only take 2 minutes to...

Hi, @majetideepak all comments were fixed. The major change is add install_protobuf in setup-adapters.sh. It make code more clear to review. And rename "linux-parquet-hive-storage-adapters-build" to "linux-adapters". Could you please review...

> @zhejiangxiaomai Which CI job is running Substrait tests? > > @majetideepak @kgpai Would you review the build script changes? Hi, @mbasmanova Linux-adapters will run Substrait tests. Because it compile...