Conditional-GAN icon indicating copy to clipboard operation
Conditional-GAN copied to clipboard

Why hardcoded constants?

Open constfilin opened this issue 6 years ago • 2 comments

On this line : https://github.com/zhangqianhui/Conditional-GAN/blob/1b4d7ea9578653b349ae5fbbd0ab4840a62578b4/model_mnist.py#L170 instead of 7*7*2*64 there should be c1*c1*2*self.batch_size.

Otherwise, why does this create variables and then neglects to use them?

constfilin avatar Oct 23 '18 18:10 constfilin

thanks

zhangqianhui avatar Oct 30 '18 14:10 zhangqianhui

JFYI: please see my code based on your conditional GAN.

constfilin avatar Oct 31 '18 07:10 constfilin