Guanheng George Zhang

Results 42 comments of Guanheng George Zhang

We have disabled our tests again due to the URL issue. https://github.com/pytorch/text/pull/888

> Can I recommend mocking that as well, then? Because our hardware occasionally has problems, and while we obviously want to fix it as quickly as possible, we also don't...

@akurniawan Just to check in and see if you have problems.

> @zhangguanheng66 yes, I have been trying to follow the code that you have given above, the one created by @cpuhrsch. It throws an error `AttributeError: 'Vocab' object has no...

> > Could you point out where `insert_tokens` is used in your code? > > It's not being used right now on the code as it throws the error I...

> > The Vocab in the main folder doesn't have `insert_token` method, however, the one in experimental folder has. Overall, no sure why you got that error because you never...

> Using the small benchmark script I found that this PR gives us a significant speedup. I didn't exactly characterize this (it's running on my laptop), but given the order...

there was a back and forth that the names of the functions were changed from `load_from_file_object` to `load_from_file`

Spacy changes the API and drops the support for the shortcut ("en"). Will sent a PR to fix it.