webpack_tutorial icon indicating copy to clipboard operation
webpack_tutorial copied to clipboard

build(deps): bump url-parse from 1.4.7 to 1.5.10

Open dependabot[bot] opened this issue 3 years ago • 0 comments

Bumps url-parse from 1.4.7 to 1.5.10.

Commits
  • 8cd4c6c 1.5.10
  • ce7a01f [fix] Improve handling of empty port
  • 0071490 [doc] Update JSDoc comment
  • a7044e3 [minor] Use more descriptive variable name
  • d547792 [security] Add credits for CVE-2022-0691
  • ad23357 1.5.9
  • 0e3fb54 [fix] Strip all control characters from the beginning of the URL
  • 61864a8 [security] Add credits for CVE-2022-0686
  • bb0104d 1.5.8
  • d5c6479 [fix] Handle the case where the port is specified but empty
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Feb 26 '22 04:02 dependabot[bot]

@blaszczakphoto you're absolutely right, there are indeed tons of dependencies currently imported into the gem and thus the Rails project that are not needed.

I unfortunately am working under a lot of deadlines at the moment, so cannot tackle this myself. However, I believe there's a relatively simple approach to separating the core requirements from the extraneous and it would be very similar to how https://github.com/jquery-ui-rails/jquery-ui-rails does it.

In a nutshell, jquery-ui-rails let's you import everything with one line:

 *= require jquery-ui

That's essentially what gentelella-rails' current require does.

To start breaking it apart, we need to take inspiration from the jquery-ui-rails project and simply introduce a core js and css that loads the core components necessary for our base functionality and then each individual asset we want to load separately. A corresponding example from jquery-ui-rails:

//= require jquery-ui/core
//= require jquery-ui/widget
//= require jquery-ui/position
//= require jquery-ui/widgets/datepicker

In this project's case, sometimes we're just making it possible to one individual library, sometimes a collection of libraries that work together. The important thing, though is to name the components well and add some info about how to pull into a fresh rails project in a piece-meal fashion.

I would also think that introducing sub-directories where it makes sense for some classes of functionalities, like the various different charts, for example.

So that's the quick 10,000 foot overview of my thoughts on the matter. If you want to help make this happen, then I'll definitely try to support you along the way. If you get started, then just think about the specific use-case you're trying to solve. Figure out what goes in the core and what goes into the includes you most need for your own project. It is fine to leave the other components out and unfinished by your own effort so that you're not overwhelmed with feeling burdened to do a "project complete" effort.

mwlang avatar Sep 05 '17 13:09 mwlang

Thanks for the quick and comprehensive answer. At the moment I decided to compile all dependencies into single file and that speed up compiling assets 5 times.

I will stay with that for now, but surely I will come back to that issue soon. When I will know more about the project and performance

mariusz-blaszczak avatar Sep 06 '17 08:09 mariusz-blaszczak