Butao Zhang

Can you fix the failed tests? http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4744/18/tests

performance regression is what we need concern about. @wecharyu has did some benchmark to validate the performance is ok after this change. But the benchmark is on the local HMS...

> do we need to do this replace in all q files? Can't we add it in https://github.com/apache/hive/blob/master/itests/util/src/main/java/org/apache/hadoop/hive/ql/QOutProcessor.java Agreed, we can refer to HIVE-19612 to mask ` totalSize` for qtests....

> @ayushtkn, @zhangbutao thanks for the review! Modified according to your suggestions. Please have a look on it! @zratkai Good! But http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4913/2/tests shows that there are still several qtests that...

@ayushtkn Any other thoughts about this change?

> We are explicitily adding MASK_TOTAL_SIZE in every file, can we have it enabled always > > ``` > public static final String HDFS_MASK = "### HDFS PATH ###"; >...

I re-run the CI, find this test always failed http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4913/14/tests Could you please take a look? @zratkai

Any further fixs & coments here? https://github.com/apache/hive/pull/5218 wants to upgrade ORC version, but hits the totalSize issue again. So i think we can continue this PR.

Hi, i am not sure if we should continue to make patch for Branch 3.1. Hive master branch code does not have this issue, I just attached a test in...

http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4993/1/pipeline serveral failed tests seems to be related this change. You can try to explore the reason.