laravel-promocodes icon indicating copy to clipboard operation
laravel-promocodes copied to clipboard

Unable to upgrade to Laravel 10

Open Elliot-putt opened this issue 2 years ago • 7 comments

   "require": {
        "illuminate/support": "^10.0.0",
        "illuminate/console": "^10.0.0",
        "illuminate/database": "^10.0.0",
        "illuminate/broadcasting": "^10.0.0",
        "illuminate/queue": "^10.0.0",
        "illuminate/container": "^10.0.0"
    },
Composer update error 

- zgabievi/laravel-promocodes 9.1.0 requires illuminate/container ^9.0 -> satisfiable by illuminate/container[v9.0.0-beta.1, ..., 9.x-dev].
    - Root composer.json requires zgabievi/laravel-promocodes ^9.1.0 -> satisfiable by zgabievi/laravel-promocodes[9.1.0].

I'm assuming this is because of the illuminate support version is specified at 9 but it should be 10.

Elliot-putt avatar Feb 15 '23 11:02 Elliot-putt

I also waiting Laravel 10 support

clickervinod avatar Feb 15 '23 11:02 clickervinod

I'm want to install on Laravel 10 too. Is this package abandoned?

ricardobarantini avatar Apr 25 '23 21:04 ricardobarantini

I'm want to install on Laravel 10 too. Is this package abandoned?

I wouldn't this still hasn't been updated!

Elliot-putt avatar Apr 26 '23 10:04 Elliot-putt

Me too :) :(

navigermobile avatar May 19 '23 10:05 navigermobile

@ricardobarantini @Elliot-putt @ricardobarantini @zgabievi

I have created a Pull request to upgrade to Laravel 10, the upgrade will work on both V10 and V9. so no breaking changes

You are welcome to use my repo https://github.com/Elshaden/laravel-promocodes.git

you have to add it to your required

"zgabievi/laravel-promocodes":"dev-L10"

You need to add the url also

"repositories": [
       
        {
           "type": "vcs",
           "url": "https://github.com/Elshaden/laravel-promocodes.git"
        }
]

Elshaden avatar Jul 04 '23 09:07 Elshaden

@Elshaden Do yout think you can add the fix https://github.com/zgabievi/laravel-promocodes/pull/111 to your repo? I need both of this fixes urgently, and @zgabievi doesn't seems to be active lately to review the pull requests :( thank you in advance

mgaratemu avatar Nov 25 '23 05:11 mgaratemu

@mgaratemu Ok Done I could not Pull your request because it was not made in My repo. so I just copied what you asked for.

Elshaden avatar Nov 26 '23 17:11 Elshaden