STID icon indicating copy to clipboard operation
STID copied to clipboard

Questions about the time of day embedding

Open mb-Ma opened this issue 1 year ago • 3 comments

I noticed that only the last time step of each sample is kept by the following code: https://github.com/zezhishao/STID/blob/f9801a5d4939e7d3eb100525c1c027cbd34630d3/stid/stid_arch/stid_arch.py#L76-L88

More specifically, the operation "t_i_d_data[:, -1, :]" is used to get the last time step from input data.

Could you please provide more interpretations?

mb-Ma avatar Aug 17 '23 14:08 mb-Ma

Thanks for your interests. For more details, you can refer to the discussion below the blog of STID in Zhihu: image

zezhishao avatar Aug 18 '23 07:08 zezhishao

Thank you for your fast response. I did not see these comments. :-)

Yeah. It seems an efficient solution. The purpose is just to identify different times when the current sample is, only one time step is okay which meets Ockham's Razor. From another perspective, (B, [all time step concat], N) compared to (B, [single time step embedding], N) is more redundant since all nodes are same time embedding in one sample.

mb-Ma avatar Aug 18 '23 09:08 mb-Ma

Thank you very much for your acknowledgment! Any further discussions are welcome~

zezhishao avatar Aug 18 '23 09:08 zezhishao