mixpanel icon indicating copy to clipboard operation
mixpanel copied to clipboard

Added support for https on Ruby 1.9.3

Open manuelmorales opened this issue 11 years ago • 5 comments

Net::HTTP.post_form on Ruby 1.9.3 won't detect the HTTPS protocol and enable SSL. This fix checks the scheme and enables it when necessary.

manuelmorales avatar Feb 11 '14 15:02 manuelmorales

Hi @manuelmorales, tests are failing, can you check it out before merge?

Thanks.

zevarito avatar Feb 11 '14 17:02 zevarito

Bundle exec rake run green for me. What version of ruby do you use? On 11 Feb 2014 17:09, "Alvaro Gil" [email protected] wrote:

Hi @manuelmorales https://github.com/manuelmorales, tests are failing, can you check it out before merge?

Thanks.

Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/pull/133#issuecomment-34776353 .

manuelmorales avatar Feb 11 '14 21:02 manuelmorales

Is not me is Travis :)

On Tue, Feb 11, 2014 at 7:42 PM, Manuel Morales [email protected]:

Bundle exec rake run green for me. What version of ruby do you use? On 11 Feb 2014 17:09, "Alvaro Gil" [email protected] wrote:

Hi @manuelmorales https://github.com/manuelmorales, tests are failing, can you check it out before merge?

Thanks.

Reply to this email directly or view it on GitHub< https://github.com/zevarito/mixpanel/pull/133#issuecomment-34776353>

.

— Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/pull/133#issuecomment-34811218 .

Alvaro

zevarito avatar Feb 12 '14 12:02 zevarito

Ups, I didn't notice that I broke the Ruby 1.9.2 build. I just fixed it. Now the build is still broken, but that's because of the already existing problem with JRuby in 1.8 mode.

manuelmorales avatar Feb 16 '14 19:02 manuelmorales

Hi @manuelmorales did you know about this project? https://github.com/mixpanel/mixpanel-ruby

It is the official Mixpanel Ruby Gem, I've stopped this Gem development in favor of that one.

Please take a look an tell me if you want to still use this Gem and I'll merge your PR.

Thanks.

zevarito avatar Feb 17 '14 14:02 zevarito