Licode-ErizoClientIOS icon indicating copy to clipboard operation
Licode-ErizoClientIOS copied to clipboard

Seems like `streamSignalingDelegates` in `ECSignalingChannel` contains `ECClient`, so it causes retain cycle.

Open allenlinli opened this issue 6 years ago • 2 comments

I am fixing a bug that caused by retain cycle between ECSignalingChannel and ECClient. I found streamSignalingDelegates retain ECClient strongly in NSMutableDictionary from, so it has retain cycle. Should we avoid this retain cycle since subscribeClient and publish client should be released if needed after disconnection?

allenlinli avatar Jan 07 '19 03:01 allenlinli

Hi Li Lin, I am not able to work on it right now, if you want to submit PR please go ahead.

El lun., 7 de ene. de 2019 a la(s) 00:46, Li Lin ([email protected]) escribió:

I am fixing a bug that caused by retain cycle between ECSignalingChannel and ECClient. I found streamSignalingDelegates retain ECClient strongly in NSMutableDictionary from, so it has retain cycle. Should we avoid this retain cycle since subscribeClient and publish client should be released if needed after disconnection?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zevarito/Licode-ErizoClientIOS/issues/85, or mute the thread https://github.com/notifications/unsubscribe-auth/AACgaueUty5oxD7tZnjr-NX7f0lMiM32ks5vAsMAgaJpZM4Zy0S5 .

-- Alvaro

zevarito avatar Jan 07 '19 19:01 zevarito

I am facing same problem. Are you sending PR or changes here? It happens to me when I quickly connect and then disconnect the call.

ashar02 avatar Jan 09 '19 15:01 ashar02