react.rb icon indicating copy to clipboard operation
react.rb copied to clipboard

calls to _react_param_conversion(json, validate_only) should pass both params

Open catmando opened this issue 9 years ago • 1 comments

Currently some someplace is calling _react_param_conversion with only the first parameter (i.e. the second is being allowed to default)

But OPAL does not check for missing parameters.

So if you add self._react_param_conversion(json, validate_only) to a class without a default, there will be no warning, validate_only will get JS 'undefined' and your methods will not work correctly

catmando avatar Dec 09 '15 15:12 catmando

This issue was moved to reactrb/reactrb#94

sollycatprint avatar Jun 13 '16 13:06 sollycatprint