David Chang

Results 59 comments of David Chang

Is this already on master? https://github.com/ruby-hyperloop/hyper-react/blob/master/lib/react/state.rb#L84

Ok, I see. The change is actually introduced by https://github.com/ruby-hyperloop/hyper-react/issues/178

Just FYI, the corresponding JSX equivalent is props spread. https://facebook.github.io/react/docs/jsx-spread.html

The `native component` referred is something imported by `React::NativeLibrary`?

I've tried by passing a Proc as ref, and it works as the original ref callback. So you could actually write like this ``` ruby class Hello < React::Component::Base attr_accessor...

@catmando , yeah, providing a callback would be consistent, but the ref callback is also called when unmount happen, so may be `.on(:ref) { |dom_node_or_instance| ... }`

The ref callback is used to save the actual instance or dom node for further manipulate, the callback will be called after mounted, and called again with `null` when element...

Is the outer_most render always happen from https://github.com/ruby-hyperloop/hyper-react/blob/master/lib/react/component.rb#L121 ? If so, we could reset the buffer right after the render finished as following diff. ```diff def _render_wrapper State.set_state_context_to(self, true) do...

I apply the patch and see when is `was_outer_most` become true by running against our test suits, and it turns out the `_render_wrapper` we place at `React::Component` seems always to...

Not sure about the first one, the method signature is different than other API we got, so it might be confusing to users. [Hyalite](https://github.com/youchan/hyalite) using API like this to implement...