refactor: omit unnecessary reassignment

[liuyueyangxmu]

Description

The new version of Go has been optimized, and variables do not need to be reassigned.

For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore

How Has This Been Tested?

• [x] Tested CCTX in localnet
• [ ] Tested in development environment
• [ ] Go unit tests
• [ ] Go integration tests
• [x] Tested via GitHub Actions

Summary by CodeRabbit

• Refactor
  • Updated internal code patterns in test suites and utility modules to improve code consistency and align with Go development best practices. No user-facing functionality changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai[bot]]

📝 Walkthrough

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description provides clear motivation referencing Go's loop variable optimization but lacks testing evidence; only 2 of 5 checkboxes are marked despite claimed testing.	Clarify which tests were actually executed and verify claims of GitHub Actions testing. Complete the testing checklist with specific evidence.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately captures the primary refactoring change: removing unnecessary variable reassignments in Go loops.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• [ ] 📝 Generate docstrings

🧪 Generate unit tests (beta)

• [ ] Create PR with unit tests
• [ ] Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 737e30d66c3538255e943c752d0f1bf67f4f9fc9 and 4d059db7bbdc641e3ae2eef379f6a73bfeb3620e.

📒 Files selected for processing (25)

• e2e/e2etests/legacy/test_rate_limiter.go (0 hunks)
• e2e/e2etests/test_stress_sui_deposit.go (0 hunks)
• e2e/e2etests/test_stress_sui_withdraw.go (0 hunks)
• e2e/utils/zetacore.go (0 hunks)
• pkg/chains/chain_test.go (0 hunks)
• pkg/os/path_test.go (0 hunks)
• x/crosschain/genesis.go (0 hunks)
• x/crosschain/keeper/abci_test.go (0 hunks)
• x/crosschain/keeper/cctx_test.go (0 hunks)
• x/crosschain/keeper/grpc_query_gas_price_test.go (0 hunks)
• x/crosschain/keeper/grpc_query_last_block_height_test.go (0 hunks)
• x/crosschain/keeper/msg_server_vote_inbound_tx_test.go (0 hunks)
• x/crosschain/keeper/msg_server_vote_outbound_tx_test.go (0 hunks)
• x/crosschain/simulation/decoders_test.go (0 hunks)
• x/emissions/simulation/decoders_test.go (0 hunks)
• x/fungible/keeper/evm_hooks_test.go (0 hunks)
• x/fungible/simulation/decoders_test.go (0 hunks)
• x/fungible/types/message_pause_zrc20_test.go (0 hunks)
• x/fungible/types/message_unpause_zrc20_test.go (0 hunks)
• x/observer/genesis.go (0 hunks)
• x/observer/keeper/grpc_query_node_account_test.go (0 hunks)
• x/observer/keeper/grpc_query_nonces_test.go (0 hunks)
• x/observer/keeper/grpc_query_tss_test.go (0 hunks)
• x/observer/simulation/decoders_test.go (0 hunks)
• x/observer/types/ballot_test.go (0 hunks)

💤 Files with no reviewable changes (25)

• x/crosschain/keeper/msg_server_vote_outbound_tx_test.go
• x/fungible/keeper/evm_hooks_test.go
• x/fungible/types/message_unpause_zrc20_test.go
• x/observer/types/ballot_test.go
• x/crosschain/keeper/abci_test.go
• x/crosschain/keeper/msg_server_vote_inbound_tx_test.go
• x/observer/keeper/grpc_query_tss_test.go
• x/emissions/simulation/decoders_test.go
• pkg/os/path_test.go
• e2e/e2etests/legacy/test_rate_limiter.go
• x/crosschain/keeper/cctx_test.go
• x/crosschain/keeper/grpc_query_last_block_height_test.go
• x/observer/keeper/grpc_query_node_account_test.go
• x/observer/keeper/grpc_query_nonces_test.go
• x/crosschain/keeper/grpc_query_gas_price_test.go
• x/fungible/simulation/decoders_test.go
• pkg/chains/chain_test.go
• x/fungible/types/message_pause_zrc20_test.go
• e2e/utils/zetacore.go
• x/crosschain/simulation/decoders_test.go
• x/observer/simulation/decoders_test.go
• e2e/e2etests/test_stress_sui_deposit.go
• e2e/e2etests/test_stress_sui_withdraw.go
• x/crosschain/genesis.go
• x/observer/genesis.go

[!TIP]

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions: | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[liuyueyangxmu]

@renan061 @lumtis Thank you for your approval.

If there's anything need I to do, please feel free to let me know.