bug: a low gas limit in ERC20 revert outbound will block whole outbound

[ws4charlie]

Describe the Bug A recent zetaclientd hotfix removed the 100K minimum gas limit check and the gas limit field in the CCTX was used instead. This caused a situation when a ERC20 revert outbound has a low gas limit 21000 and blocks outbound due to the error intrinsic gas too low.

The blocked CCTX in BASE was this one.

To unblock the outbound without zetacore change, we added back the 100K gas limit check only for ERC20 token in a zetaclient-only hotfix.

Expected Behavior

I think a proper gas limit should be used for ERC20 revert outbound in order to both charge correct gas fee from end user and avoid blocked outbound.

[lumtis]

There are two issues:

• If a revert happens, either gas limit in revertOptions should be used, otherwise the default gas limit of the ZRC20 (should have been 100000 for this cctx)
• Outbounds shouldn't be blocked because of low gas limit, if this happens we should have a mechanism to revert the transaction

This issue looks more outlining the first problem, I will create an issue for the second one

[CharlieMc0]

Can this be closed? @ws4charlie

[kingpinXD]

We should, overwrite the limit if the one provided is too low when updating the revertOptions for the cctx

[lumtis]

The initial issue with the wrong gas limit set was fixed, Outbound with gas limit too low should not block outbounds #3725 is the followup