node icon indicating copy to clipboard operation
node copied to clipboard

`zetacore` : ZetaAccounting is incorrectly set during InitGenesis of crosschain module

Open kingpinXD opened this issue 1 year ago • 2 comments

We set ZetaAccounting here https://github.com/zeta-chain/zeta-node/blob/a8236ed03212ab3c30efd5dbccc3d62d582e7900/x/crosschain/genesis.go#L13-L13

This directly copies and sets the existing value to state.

However, The value is also updated ( Aborted amount is added ) when saving the CCTX's https://github.com/zeta-chain/zeta-node/blob/a8236ed03212ab3c30efd5dbccc3d62d582e7900/x/crosschain/genesis.go#L47-L53

This behaviour should be modified to properly set accounting

kingpinXD avatar Dec 04 '24 22:12 kingpinXD

Considering to close this one, I don't think we use ZetaAccounting in anyway

lumtis avatar Mar 12 '25 09:03 lumtis

Yes we can close this

kingpinXD avatar Apr 24 '25 19:04 kingpinXD