node icon indicating copy to clipboard operation
node copied to clipboard

Unknown field errors when querying pre-v19 height cosmos transactions

Open GMaiolo opened this issue 1 year ago • 5 comments

Describe the Bug When querying /cosmos/tx/v1beta1/txs?events=tx.height=4667204&page=1&limit=100&pagination.count_total=true With heights previous to the v19 update, nodes fail errors like the following

{
  "code": 2,
  "message": "codespace sdk code 2: tx parse error: errUnknownField \"*types.MsgVoteGasPrice\": {TagNum: 5, WireType:\"bytes\"}",
  "details": []
}

To Reproduce Query a pre-v19 block like /cosmos/tx/v1beta1/txs?events=tx.height=4667204&page=1&limit=100&pagination.count_total=true

Expected Behavior Transactions data should be returned successfully

GMaiolo avatar Sep 05 '24 23:09 GMaiolo

Another example /cosmos/tx/v1beta1/txs?events=tx.height=4687821&page=1&limit=1&pagination.count_total=true

Result

{
  "code": 2,
  "message": "codespace sdk code 2: tx parse error: unable to resolve type URL /zetachain.zetacore.crosschain.MsgVoteOnObservedInboundTx",
  "details": []
}

GMaiolo avatar Sep 09 '24 15:09 GMaiolo

Both the example contain proto buffers which have been modified

  • VoteGasPrice . The supply field with ID 5 was removed
  • MsgVoteOnObservedInboundTx was renamed to VoteInbound

kingpinXD avatar Sep 09 '24 16:09 kingpinXD

@kingpinXD would this impact someone that tries to create an indexer for ZetaChain from genesis?

GMaiolo avatar Sep 16 '24 21:09 GMaiolo

This would impact someone trying to sync from block 1 , if they use the current binary and try to fetch older transactions

kingpinXD avatar Sep 17 '24 09:09 kingpinXD

v21 modifies the UpdateChainInfo message , and is a breaking change We should verify on athens 3 , that we do not run into a similar issues as this https://github.com/zeta-chain/node/pull/2890

kingpinXD avatar Sep 18 '24 01:09 kingpinXD

@lumtis does this need an update on the nodes?

GMaiolo avatar Oct 15 '24 18:10 GMaiolo