node icon indicating copy to clipboard operation
node copied to clipboard

Separate messages for each required policy group

Open lumtis opened this issue 1 year ago • 3 comments

https://github.com/zeta-chain/node/pull/1552#discussion_r1449091703

For simplicity and better maintainability, each message should have a single policy group requirement.

We should change it for MsgUpdateCrosschainFlags and list other message with different policy group requirements

lumtis avatar Jan 11 '24 18:01 lumtis

We can refactor into the following messages. cc @lumtis

// MsgDisableCCTXflags -> PolicyType_groupEmergency
// Disable inbound and outbound transactions , Disable both or any one

// MsgEnableCCTXflags -> PolicyType_groupOperational
// Enable inbound and outbound transactions , Enable both or any one

// MsgUpdateGasPriceFlags -> PolicyType_groupOperational . Update values
// Update gas price flags

kingpinXD avatar May 02 '24 05:05 kingpinXD

Yes, this can looks like this.

lumtis avatar May 02 '24 12:05 lumtis

Broke this down into issue #2244 and #2245

kingpinXD avatar May 23 '24 11:05 kingpinXD

Closing this issue , and working on the new issues listed above

kingpinXD avatar Jun 03 '24 17:06 kingpinXD