manager-ui icon indicating copy to clipboard operation
manager-ui copied to clipboard

Warn user when deleting model if code file will also be deleted (pending merge)

Open jomarmontuya opened this issue 11 months ago • 6 comments

jomarmontuya avatar Mar 18 '24 22:03 jomarmontuya

@giseleblair is it possible for you to give me more context on where this issue is? and how I can posibly replicate this?

Thank you!

jomarmontuya avatar Mar 18 '24 22:03 jomarmontuya

When a user deletes a model from the Schema app, it is not clear whether or not the associate view (code) file will also be deleted. To replicate: Go to Schema. Delete a content model. See if the associate view (code) file was deleted. If yes: we should warn the user about this action If no: should the file also be removed? It can be confusing to have a lingering view file after a model is deleted

giseleblair avatar Mar 19 '24 14:03 giseleblair

  1. Jomar do not tackle this ticket yet. This will need a design to accompany it which I can make now.

  2. Gisele please answer the following:

a. What are the implications (if any) of us deleting the view file along with the model?

b. Has any customer reported this issue in the last 6 months?

c. Do we give any warnings in the code app if a model that is deleted is being referenced in files (outside of the view file)?

On Tue, Mar 19, 2024, 7:32 PM Gisele Blair @.***> wrote:

When a user deletes a model from the Schema app, it is not clear whether or not the associate view (code) file will also be deleted. To replicate: Go to Schema. Delete a content model. See if the associate view (code) file was deleted. If yes: we should warn the user about this action If no: should the file also be removed? It can be confusing to have a lingering view file after a model is deleted

— Reply to this email directly, view it on GitHub https://github.com/zesty-io/manager-ui/issues/2596#issuecomment-2007263378, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMT475QKGFRGWQZDQ334CLYZBAOZAVCNFSM6AAAAABE4OYNKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGI3DGMZXHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

zcolah avatar Mar 20 '24 01:03 zcolah

@zcolah a. if a code file is deleted that is just it, a code file has been deleted. We have no insight on how code files are used when they are not associated to a content model.

b. This has not been reported by a customer in the last 6 months.

c. There are no warnings regarding code files when a model is deleted

giseleblair avatar Mar 20 '24 13:03 giseleblair

Hey @zcolah is this ticket going to be tackled elsewhere or do we have an existing already to be used for this?

finnar-bin avatar May 08 '24 22:05 finnar-bin

Hey @finnar-bin This ticket is added to our backlog. No action should be taken.

zcolah avatar May 13 '24 09:05 zcolah