manager-ui icon indicating copy to clipboard operation
manager-ui copied to clipboard

Content App: Update Device Resolutions

Open zcolah opened this issue 2 years ago • 1 comments

These sizes are very old. image

Please update device viewport resolutions to the following list: Viewport List

@shrunyan need to know if we can do tablet and desktop sizes. See above example I am suggesting.

zcolah avatar Oct 21 '22 20:10 zcolah

Let us complete this ticket with only the mobile device sizes to get started.

zcolah avatar Mar 14 '23 17:03 zcolah

The device shapes are being rendered with CSS. This is quite complicated styling not something we are looking to update. To replicate the experience with newer models we should use images of the devices we would like to display. This requires sourcing clean accurately sized images of these devices.

shrunyan avatar Mar 14 '23 18:03 shrunyan

Additionally the list of devices offered should probably be consistent with current global market share. e.g. https://www.counterpointresearch.com/top-5-smartphone-model-share-8-countries/

shrunyan avatar Mar 14 '23 18:03 shrunyan

@shrunyan I can source clean accurately sized images of these devices.

With respect to the list. It only shows the best selling devices for a quarter. It does not necessarily represent the total market share of devices being used in the world. Hence it may be helpful for us to use the same list as Figma, who has already most likely invested the time and research to narrow down on this list.

zcolah avatar Mar 14 '23 18:03 zcolah

related https://github.com/zesty-io/manager-ui/issues/461

shrunyan avatar Mar 24 '23 20:03 shrunyan

@zcolah bump on these to get device images to support this update

ardeay avatar May 26 '23 13:05 ardeay

Figma Link with Resolutions https://www.figma.com/file/ZlBzMHeABFPPntjrvMDd0s/Device-Screenshots?type=design&node-id=0%3A1&t=t6hcVoO7DdB64WyL-1

Screenshots

iPad Pro iPhone 14 Pro iPhone 14 Pixel 7

zcolah avatar May 31 '23 20:05 zcolah