pollster icon indicating copy to clipboard operation
pollster copied to clipboard

Use pin macro to remove all unsafe

Open Manishearth opened this issue 2 years ago • 4 comments

Manishearth avatar Nov 12 '23 16:11 Manishearth

Doesn't this raise the MSRV to 1.68.0?

notgull avatar Nov 12 '23 17:11 notgull

oh, I wasn't aware there was an MSRV.

Manishearth avatar Nov 13 '23 01:11 Manishearth

Ah, yep. MSRV is the current reason for not using pin! (although I'm extremely glad it made it into std!). I believe #16 does the same thing. Perhaps in a few months to a year I'll raise the MSRV but since this crate suddenly seems to be quite popular and sits at the bottom of a lot of dependency trees in the ecosystem, I want to avoid bumping it unless there's a solid, quantifiable reason for bumping. Thanks for opening the PR though :)

zesterer avatar Nov 13 '23 17:11 zesterer

Sounds good!

Manishearth avatar Nov 13 '23 20:11 Manishearth