Joshua Barretto
Joshua Barretto
I disagree that the functions are redundant. Creating a report inline and modifying an existing report are two conceptually distinct operations.
Looks like there's a bit more to do on this PR: adding a few `Clone` constraints in derives. It's likely going to be a breaking change.
It looks like it just needs someone to pick it up again.
The comment in that file only really relates to the logic for actually generating a diagnostic. Implementing `Clone` for `ReportBuilder` is just a case of writing a manual `Clone` impl...
This seems expected. `Report::build` on its own does not imply any particular type parameters. `Report` is generic over the span type, to a span type must be hinted at somewhere...
It's quite common, yes. Without a label, there's no reference in the source code. In cases where a label is really not desired for some reason, the span type can...
I am - very slowly - working on a refactor of ariadne, which should address this issue.
I'll add this feature to the refactor I'm currently working on!
This is not yet fixed, but is visually improved in `0.1.5`, which has just been released. There is at least an indicator for the skipped lines now.