eslint-plugin-dependencies Added support for breaking change in eslint v6+

Added support for breaking change in eslint v6+

Open roniger opened this issue 5 years ago • 11 comments

Jun 25 '19 08:06 roniger

Please, accept this PR

Jun 27 '19 09:06 pladaria

Better approach is to not rely on internal ESLint functions at all. See https://github.com/vuejs/eslint-plugin-vue/pull/910 for comparison.

Sep 06 '19 15:09 gabegorelick

Agreed. Are you making the change?

On Fri, Sep 6, 2019 at 6:45 PM Gabe Gorelick [email protected] wrote:

Better approach is to not rely on internal ESLint functions at all. See vuejs/eslint-plugin-vue#910 https://github.com/vuejs/eslint-plugin-vue/pull/910 for comparison.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zertosh/eslint-plugin-dependencies/pull/21?email_source=notifications&email_token=AAHKXF2ETWGQKXFV42YCGEDQIJ3JRA5CNFSM4H3FWDMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DH2QI#issuecomment-528907585, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHKXF2XVVIALESO4GH3XUTQIJ3JRANCNFSM4H3FWDMA .

Sep 06 '19 17:09 roniger

I would be happy to, but since there is no indication that any PR will get merged (none since 2017), I wasn't planning on it. See the (currently one-sided) discussion on https://github.com/zertosh/eslint-plugin-dependencies/issues/23.

Sep 06 '19 17:09 gabegorelick

Yes, it does look abandoned. I gave up on this initiative a while ago Doesn't seem like there will be any feedback any time soon

On Fri, Sep 6, 2019 at 8:59 PM Gabe Gorelick [email protected] wrote:

I would be happy to, but since there is no indication that any PR will get merged (none since 2017), I wasn't planning on it. See the (currently one-sided) discussion on #23 https://github.com/zertosh/eslint-plugin-dependencies/issues/23.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zertosh/eslint-plugin-dependencies/pull/21?email_source=notifications&email_token=AAHKXF75IHK3NQVEDJNPA7LQIKK6BA5CNFSM4H3FWDMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6DTEKI#issuecomment-528953897, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHKXF57DJGPPSS5COM4JN3QIKK6BANCNFSM4H3FWDMA .

Sep 06 '19 18:09 roniger

@roniger @gabegorelick

I considered at some point doing a published fork, but give up when realised that the plugin eslint-plugin-import does the job (and way more)

Here are the equivalent rules:

dependencies/no-cycles -> import/no-cycle: doc
dependencies/no-unresolved + dependencies/case-sensitive -> import/no-unresolved: doc
- ⚠️ beware option is needed for require ({"commonjs": true})
- for case sensitivity use the caseSensitive option
dependencies/require-json-ext -> import/extensions: doc

Here is the list of all the rules: https://github.com/benmosher/eslint-plugin-import#rules

Oct 11 '19 21:10 AdrieanKhisbe

☝️

that could interest you too @pladaria :)

and also everyone that 👍 the issues and comment @despairblue, @Stegoo, @edi9999, @lynxtaa, @yelworc, @AdriVanHoudt, @mkamakura, @ErideDLF, @d2phap, @lynxtaa, @oknechirik

Oct 11 '19 21:10 AdrieanKhisbe

import/no-cycle doesn't work for commonjs.

Oct 11 '19 22:10 gabegorelick

@AdrieanKhisbe We did exactly the same long time ago! 👍

Oct 11 '19 23:10 mrtnzlml

@AdrieanKhisbe sadly import/no-cycle doesn't work well with flowtype https://github.com/benmosher/eslint-plugin-import/issues/1343 And looks like it has similar issues with typescript: https://github.com/benmosher/eslint-plugin-import/issues/1453

We finally did an internal fork of this plugin

Oct 21 '19 07:10 pladaria

@pladaria, would this fix your issue?

https://github.com/benmosher/eslint-plugin-import/pull/1494