Andres Suarez

Results 73 comments of Andres Suarez

> however, were there a flag to specify that the module doesn't need Buffer, this could be solved by resolving Buffer to undefined until another module exists in the package...

Yup. They're taken as given from the options. This isn't a bug.

Hey @zachrose, is this something you're still interested in? Just asking to see if I should spend time on it or not since it's been 5 months :disappointed:

So here's how it works: Remember that node's `require` resolves paths relative to the caller. Browserify tries really hard to behave this way. So when you pass in a string...

This is being discussed in https://github.com/substack/node-browserify/pull/1151

The commit is straightforward, but the consequences are not. Last time I looked at this, there were problems with the standalone option.

`umd.postlude(...)` returns `});`, so when you use both sourcemaps and standalone, you end up with double `;`

@zoubin I took a quick glance and realized that this is going to require serious thought - Give me a few days to clear up some time for this.

`params` gets passed to `resolve` as `opts`, where it's given a [default value of `[]`](https://github.com/substack/node-resolve/blob/38d451c0ecd9267277a7683970432d37f001441e/lib/async.js#L32). By passing `self.paths`, it'll actually get a [value](https://github.com/substack/module-deps/blob/bb388ab4194e8155764600f339fdeb18d1c690b8/index.js#L40). I think there's an expectation that modules...