ZeroTierOne icon indicating copy to clipboard operation
ZeroTierOne copied to clipboard

Add Arm64 Support for Windows

Open chenx-dust opened this issue 2 years ago • 2 comments

It works well now on my Surface Pro X.

chenx-dust avatar Jul 27 '22 07:07 chenx-dust

Some important information should be declared: I found some buiding problems in the module zeroidc, when using --target=aarch64-pc-windows-msvc on my amd64 computer. I spotted that it was caused by an upstream module ring, which doesn't work properly at the version 0.16.20. Therefore, I try to update it to the github version of it. The non-released 0.17 version works well, but the new one is incompatible with other modules😂. Thus, the only thing I could do was to use the patch feature of cargo, which might, however, cause some unexpectable problems when other modules update. Anyway, it works now😊.

Some code refes to https://github.com/briansmith/ring/commit/ceb5b90f6e9d6e11f7b18d41a500e1edd99b2f87

chenx-dust avatar Jul 27 '22 08:07 chenx-dust

I would like it very much to see this get into the product.

conioh avatar Aug 14 '22 19:08 conioh

This is interesting. Any movement on getting it added?

dmkjr avatar Sep 25 '22 21:09 dmkjr

Would love to see this get reviewed and merged as well!

hoamle avatar Jan 03 '23 06:01 hoamle

Sad.

conioh avatar Jan 07 '23 15:01 conioh

Sad.

Well, I guess the reason why this pr was closed might be I wrongly chose to merge it into the master branch, which should be dev branch. I can open a new pr, but I'm sorry that I've sold my Surface Pro X, thus making it impossible for me to test whether the code works. So I hope someone who is interested in this work to pull request.

chenx-dust avatar Jan 07 '23 15:01 chenx-dust

Hello!

Sorry about that. I was doing some maintenance for our Github organization, trying to normalize all the branch names, and settings.... this was automatically closed when I deleted the master branch.

Please re-open against dev... I'll work on getting some Windows builds into CI for this.

-s

someara avatar Jan 07 '23 16:01 someara

Hello!

Sorry about that. I was doing some maintenance for our Github organization, trying to normalize all the branch names, and settings.... this was automatically closed when I deleted the master branch.

Please re-open against dev... I'll work on getting some Windows builds into CI for this.

-s

Never mind. I've opened a new one. https://github.com/zerotier/ZeroTierOne/pull/1837

chenx-dust avatar Jan 07 '23 16:01 chenx-dust

Thanks!

someara avatar Jan 07 '23 16:01 someara