ZeroTierOne
ZeroTierOne copied to clipboard
Add Arm64 Support for Windows
It works well now on my Surface Pro X.
Some important information should be declared:
I found some buiding problems in the module zeroidc
, when using --target=aarch64-pc-windows-msvc
on my amd64 computer. I spotted that it was caused by an upstream module ring
, which doesn't work properly at the version 0.16.20
.
Therefore, I try to update it to the github version of it. The non-released 0.17 version works well, but the new one is incompatible with other modules😂. Thus, the only thing I could do was to use the patch feature of cargo, which might, however, cause some unexpectable problems when other modules update. Anyway, it works now😊.
Some code refes to https://github.com/briansmith/ring/commit/ceb5b90f6e9d6e11f7b18d41a500e1edd99b2f87
I would like it very much to see this get into the product.
This is interesting. Any movement on getting it added?
Would love to see this get reviewed and merged as well!
Sad.
Sad.
Well, I guess the reason why this pr was closed might be I wrongly chose to merge it into the master branch, which should be dev branch. I can open a new pr, but I'm sorry that I've sold my Surface Pro X, thus making it impossible for me to test whether the code works. So I hope someone who is interested in this work to pull request.
Hello!
Sorry about that. I was doing some maintenance for our Github organization, trying to normalize all the branch names, and settings.... this was automatically closed when I deleted the master branch.
Please re-open against dev... I'll work on getting some Windows builds into CI for this.
-s
Hello!
Sorry about that. I was doing some maintenance for our Github organization, trying to normalize all the branch names, and settings.... this was automatically closed when I deleted the master branch.
Please re-open against dev... I'll work on getting some Windows builds into CI for this.
-s
Never mind. I've opened a new one. https://github.com/zerotier/ZeroTierOne/pull/1837
Thanks!