Matt Topol

Results 140 comments of Matt Topol

@davidwendt I'm starting to work on the gtests now

@davidwendt @bdice @vyasr I need a little bit of assistance if anyone has a moment. I'm trying to put the tests together but I'm not `cmake` savvy enough to figure...

@vyasr the issue i'm having with building the tests is that I can't figure out where to modify the `CMakeLists.txt` in the tests directory so that it can find the...

@erratic-pattern thanks for doing this. As far as how the tests are structured, there's three primary files specific to flightsql: - `client_test.go`: contains a mocked `GrpcClientStream` object and a mock...

@erratic-pattern in general this looks okay, but the build needs to be fixed as I'm seeing ``` # github.com/apache/arrow/go/v16/arrow/flight/flightsql Error: flight\flightsql\server.go:979:16: undefined: flight.DoPutPreparedStatementResult ``` In the CI

@lidavidm @danepitkin Would either of you be able to look into the Java side here and confirm if the issue is on the Java client or if the Go side...

Probably, since we'd want to expose the new functionality for that. But that wouldn't explain the java failure though

@erratic-pattern that failure isn't related to this change, I've seen it a few times but haven't yet been able to figure out the cause. It appears to be a race...

@matthewmturner We don't need to wait for that unrelated issue to be addressed. Once the merge conflict is addressed, i'll merge this

I pretty much agree with everything that's been said. I don't think that such a field would end up providing anything particularly useful over what exists or that would actually...