libzmq icon indicating copy to clipboard operation
libzmq copied to clipboard

"configure --help" output doesn't match actual behaviour

Open ellert opened this issue 2 years ago • 0 comments

What is the intended behaviour here?

  • The documented behaviour from "configure --help", i.e. drafts enabled by default, or
  • The implemented behaviour, i.e. drafts disabled by default (unless building from a git checkout).

https://github.com/zeromq/libzmq/blob/f0c471aaabb7f619fc0569317e300f28d00a22ec/configure.ac#L1029-L1042

I would prefer to change the implemented behaviour to match the documented behaviour, i.e.

AC_ARG_ENABLE([drafts], 
    AS_HELP_STRING([--enable-drafts], 
        [Build and install draft classes and methods [default=yes]]), 
    [enable_drafts=$enableval], 
    [enable_drafts=yes]) 

(and remove the definition of the now unused defaultval).

But if this is not acceptible, change the documentation to match the implementation:

AC_ARG_ENABLE([drafts], 
    AS_HELP_STRING([--enable-drafts], 
        [Build and install draft classes and methods [default=$defaultval]]), 
    [enable_drafts=$enableval], 
    [enable_drafts=$defaultval]) 

As it is now, users reading the output of "configure --help" think they have drafts enabled when they actually have not.

ellert avatar Oct 31 '23 04:10 ellert