ZAP request identity frame may not match spec

[Zabot]

Reading through the RFC for ZAP the 6th frame of a ZAP request is identity, defined as

identity: this provides the Identity metadata property, if any, provided by the connection. It SHALL be a binary string no longer than 255 bytes.

The examples also shows the identity frame in use

+-+
| |                 Empty delimiter frame
+-+---+
| 1.0 |             Version number
+-----++
| 0001 |            Request ID, for example "0001"
+------+
| test |            Domain
+------+-------+
| 192.168.55.1 |    Address
+------+-------+
| BOB  |            Identity property
+------+
| NULL |            Mechanism
+------+

Both of these suggest that the identity frame should be the identity provided by the client socket attempting to connect. However, in practice the identity frame is being populated with the identity of the server socket.

Having access to the identity of the client ensures that a connection to a router must be authorized for a particular identity before it can receive messages addressed to that identity. The current behavior seems significantly less useful.

[stale[bot]]

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.