cppzmq icon indicating copy to clipboard operation
cppzmq copied to clipboard

Remove ENABLE_DRAFTS option

Open stephanlachnit opened this issue 3 years ago • 7 comments

This option added ZMQ_BUILD_DRAFT_API to the compile definitions. However, this should be propagated by libzmq (see https://github.com/zeromq/libzmq/pull/4323 and https://github.com/zeromq/cppzmq/issues/477).

Closes https://github.com/zeromq/cppzmq/issues/477.

stephanlachnit avatar Jul 29 '22 20:07 stephanlachnit

I am not sure if I understand the problem here completely. Shutting down monitoring right is rather tricky, unfortunately. I am currently investigating an issue in libzmq related to that as well. Could you share a test case that demonstrates the problem?

coveralls avatar Aug 02 '22 10:08 coveralls

This change will probably break something for someone using slightly older versions of libzmq.

gummif avatar Aug 02 '22 10:08 gummif

This change will probably break something for someone using slightly older versions of libzmq.

Yes, I would recommend merging this change only after a new release of libzmq (the commit in question is not part of a release yet), since it is fairly reasonable to expect people not to take a new version of cppzmq and an old version libzmq.

stephanlachnit avatar Aug 02 '22 11:08 stephanlachnit

@gummif since libzmq v4.3.5 has been released with https://github.com/zeromq/libzmq/issues/4194 included, this can merged now

stephanlachnit avatar Nov 20 '23 23:11 stephanlachnit

I also updated the CI to use 4.3.5. to actually use this change.

stephanlachnit avatar Nov 22 '23 12:11 stephanlachnit

Sorry for the delay. I will see if I have time soon to do a review.

gummif avatar Dec 07 '23 20:12 gummif

@gummif friendly ping to check this :) This is quite a small change

stephanlachnit avatar Apr 22 '24 08:04 stephanlachnit