Please consider consuming an official release of catch, rather than consuming a branch directly

[robbie-daniels]

I tried building cppzmq today, and get the following issue when running cmake:

CMake Error at tests/CMakeLists.txt:47 (catch_discover_tests):
Unknown CMake command "catch_discover_tests".

I believe that this is because of this line, in which you are consuming a particular branch of catch2 which has recently been deleted (the link 404s).

Any reason why you don't just consume a release? I believe that this would be more robust to branches getting deleted from your dependencies like this.

[gummif]

This link works https://raw.githubusercontent.com/catchorg/Catch2/Catch1.x/single_include/catch.hpp but you are right, this should be https://github.com/catchorg/Catch2/releases/download/v1.12.2/catch.hpp instead.

[shalen-original]

This is also likely the same issue as #433 and #334, once the PR is accepted those can probably be closed too.

[albestro]

I started working on a PR #466 for migrating/updating to Catch2.