go-zero icon indicating copy to clipboard operation
go-zero copied to clipboard

[bugfix] add go work use project_name

Open reatang opened this issue 2 years ago • 3 comments

If the go.work file exists in the parent directory after the project is created, but the project directory is not added, it will cause the situation that go list -json -m in the current workspace does not return new project info

reatang avatar Jul 13 '23 12:07 reatang

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.25%. Comparing base (7568674) to head (6e757e7). Report is 556 commits behind head on master.

Additional details and impacted files

see 52 files with indirect coverage changes

codecov[bot] avatar Jul 13 '23 12:07 codecov[bot]

If the go.work file exists in the parent directory after the project is created, but the project directory is not added, it will cause the situation that go list -json -m in the current workspace does not return new project info

What about the parent's parent dir? Like go mod tidy, The best solution is to handle it manually.

kesonan avatar Jul 14 '23 08:07 kesonan

If the go.work file exists in the parent directory after the project is created, but the project directory is not added, it will cause the situation that go list -json -m in the current workspace does not return new project info

What about the parent's parent dir? Like go mod tidy, The best solution is to handle it manually.

If it can be handled manually, I will not submit this PR.

function getRealModule will return no matched module.

reatang avatar Jul 14 '23 10:07 reatang