go-zero icon indicating copy to clipboard operation
go-zero copied to clipboard

feat(logx): support global output serviceName field

Open chenquan opened this issue 1 year ago β€’ 4 comments

resolve #2351

chenquan avatar Sep 04 '22 10:09 chenquan

PTAL @kevwan @charmfocus

chenquan avatar Sep 05 '22 10:09 chenquan

Bot detected the issue body's language is not English, translate it automatically. πŸ‘―πŸ‘­πŸ»πŸ§‘β€πŸ€β€πŸ§‘πŸ‘«πŸ§‘πŸΏβ€πŸ€β€πŸ§‘πŸ»πŸ‘©πŸΎβ€πŸ€β€πŸ‘¨πŸΏπŸ‘¬πŸΏ


ASK @kevwan @charmfocus

Issues-translate-bot avatar Sep 05 '22 10:09 Issues-translate-bot

my 2 cents.

This is not useful in production, especially in microservices env. Reasons:

  • in k8s, filebit collect the log with app name
  • in raw deployment, different services use different files, usually we don't use system log, so no point to append service name in log.

genewoo avatar Sep 12 '22 16:09 genewoo

Thank you for your advice. we'll discuss it internally. πŸ˜„

chenquan avatar Sep 15 '22 01:09 chenquan