copilot.el icon indicating copy to clipboard operation
copilot.el copied to clipboard

feat(version): Upgrade to Copilot 1.40.0

Open knilink opened this issue 1 year ago • 2 comments

update lsp to 1.40

  • added initialized notification which required by later lsp server
  • updated script entry from agent.js to language-server.js, assuming not supporting backward compatible since copilot.el enforcing copilot-node-server's version

i am not subscribing copilot and only tested with modded lsp server based on copilot.vim so may need someone else help testing it

P.S. proposed copilot-node-server to add executable entry point https://github.com/jfcherng/copilot-node-server/issues/17 so start from next release the server should be easily started by npx -y [email protected] --stdio therefor can consider simplify the installation and version management later

knilink avatar Sep 07 '24 07:09 knilink

FWIW (I am not part of the copilot-emacs project but just an avid user), the upstream copilot.vim project renamed the agent.js file to language-server.js in the 1.34.0 release, so you will also need to update the references to this as well in copilot--server-executable - but otherwise I tested this briefly and it works for me! Thanks.

alexmurray avatar Sep 09 '24 02:09 alexmurray

the upstream copilot.vim project renamed the agent.js file to language-server.js in the 1.34.0 release

Yes, this kind of issue can be avoided by @knilink's proposal. It can be directly dealt at https://github.com/jfcherng/copilot-node-server/blob/a4a18ba57b6a21c416c60b6037e46c177529ac10/package.json#L6 if the user uses npx to start the server.

jfcherng avatar Sep 12 '24 08:09 jfcherng

I had a problem with copilot.el not working on some file. Enabling logs I had the following message: Copilot is disabled because we could not fetch the repository policy After tinkering it appears that being in a git tracked directory triggered the problem.

Not sure what the issue is but upgrading with this PR seems to fix the issue. Thanks

patzy avatar Jan 15 '25 17:01 patzy

How does it deal with #346 ?

rakotomandimby avatar Jan 15 '25 19:01 rakotomandimby

How does it deal with #346 ?

It should resolve that issue.

kiennq avatar Feb 16 '25 10:02 kiennq

Seems https://github.com/copilot-emacs/copilot.el/pull/363 rendered this obsolete.

bbatsov avatar Mar 30 '25 14:03 bbatsov