KAMI
KAMI copied to clipboard
zeroeightysix
Feature: Client auto updater
It would be pretty great if KAMI could auto-update itself when a new release is available, instead of downloading the jar manually
Also, if this simply updated the updated files and added the new files, instead of replacing it completely would make if more efficient and if you've modded the files like to disable the injection it keeps those modifications
I mean, I already have auto-build setup on my fork, currently builds and releases the artifact if the commit is marked as a release. Wouldn't be hard to add to the official KAMI repo either
Just leaving this here for reference, this is a pain in the ass to support on Windows due to Windows FS locking the mod file, even though it's technically loaded into ram, the only way to do it is with the game closed or by replacing the file's classes yourself, which screws any idea of adding version numbers in file names.
What about us Linux users ;)
On Mon, Aug 31, 2020, 2:14 PM Dominika [email protected] wrote:
Just leaving this here for reference, this is a pain in the ass to support on Windows due to Windows FS locking the mod file, even though it's technically loaded into ram, the only way to do it is with the game closed or by replacing the file's classes yourself, which screws any idea of adding version numbers in file names.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zeroeightysix/KAMI/issues/83#issuecomment-684043850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYTD5EQ4WXEOSGARQVAP5LSDQHDPANCNFSM4F7WTQWQ .
It is much easier on Linux. It seems like it's almost impossible on OSX, I couldn't get Java's File.delete() to work, I probably had to ask for permission or something.
On Linux you can just delete the old file and download the new one while running, no problem, without any issues.
I don't think this is a good idea. kami is very easy to update due to being a fabric mod (unlike other mods like impact). This in my opinion may also not be desirable. For example what if I work on my fork and it thinks it's an outdated version, or I wanna use an old version for whatever reason. That could get really annoying.
It is much easier on Linux. It seems like it's almost impossible on OSX, I couldn't get Java's File.delete() to work, I probably had to ask for permission or something.
On Linux you can just delete the old file and download the new one while running, no problem, without any issues.
Even though it seems like KAMI isn't getting an auto-updater one approach you could take is having a daemon type process that handles updating.
This has already been done with Wurst client. (GPL v3) https://github.com/Wurst-Imperium/Wurst7/blob/master/src/main/java/net/wurstclient/update/WurstUpdater.java
I think you guys could use this as well.
Sorry I dont really understand code. Is this the right one? (GPL v3) https://github.com/Wurst-Imperium/Wurst7/blob/master/src/main/java/net/wurstclient/update/Version.java
No, that just checks if the current version is the latest one, and gives you a link to the Wurst website
That is the same Version.java in the update folder, it only checks if the current version is out of date lol