KAMI icon indicating copy to clipboard operation
KAMI copied to clipboard

[feature] Adjustable font size

Open Avanatiker opened this issue 3 years ago • 4 comments

Adds a font size slider instead of having hardcoded font sizes and redundant fonts in selector.

Also size 24 is way to small for 4k displays. Thats why i added this in the first place.

Current problem: Font needs to get updated when slider gets changed. Dont know how to do that yet. Help apprechiated.

Also: I cant login with my mc account in IDE and need to build it then put it into MultiMC and run it from there. Also i need to close IntelliJ all the time when i do a new build bc i cant delete the last build jar bc its opened in Java wtf

org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':remapJar'.
Caused by: java.nio.file.FileSystemException: C:\Users\Christian\Documents\GitKraken\KAMI\build\libs\KAMI-1.16.5-feb.jar: Der Prozess kann nicht auf die Datei zugreifen, da sie von einem anderen Prozess verwendet wird.

	at com.sun.nio.zipfs.ZipFileSystem.sync(ZipFileSystem.java:1312)
	at com.sun.nio.zipfs.ZipFileSystem.close(ZipFileSystem.java:277)
	at net.fabricmc.tinyremapper.OutputConsumerPath.close(OutputConsumerPath.java:317)
	at net.fabricmc.loom.task.RemapJarTask.doSingleRemap(RemapJarTask.java:136)
	... 121 more

Avanatiker avatar Mar 05 '21 17:03 Avanatiker

Current problem: Font needs to get updated when slider gets changed. Dont know how to do that yet. Help apprechiated.

Unfortunately, fonts being finalised at initialisation is one of the drawbacks of imgui. You could try adding a button to re-initialise the GUI?

I cant login with my mc account in IDE and need to build it then put it into MultiMC and run it from there

Is there a need to log in? Just run the idea task to generate run configurations, and you'll be able to run KAMI from the IDE and test in singleplayer without logging in.

Also i need to close IntelliJ all the time when i do a new build bc i cant delete the last build jar bc its opened in Java wtf

Not sure why IntelliJ isn't closing the file handle. Sorry.

zeroeightysix avatar Mar 06 '21 23:03 zeroeightysix

I think its closer to reality to test on actual servers thats why i would enjoy to log in. I tried adding the https://github.com/Earthcomputer/multiconnect/blob/master/setupRealMcAccount.gradle to make fabric login but iam not that well versed with gradle.

Avanatiker avatar Mar 08 '21 23:03 Avanatiker

I doubt the behaviour of changing your font size changes when on a server compared to in singleplayer. It is not necessary to go through the trouble of building and exporting KAMI just to be able to log in - this way you also sacrifice being able to use debug tools in IDE, and just takes up more time.

zeroeightysix avatar Mar 08 '21 23:03 zeroeightysix

I did ask about this because the module i wanted to add would need me to test in multiplayer. Of course its not nessesary for simple things like changing font size. But i wanted to check out the codebase a bit while doing smth productive. The current setup iam forced to use: 1. Close IDE > 2. Open IDE > 3. Compile > 4. Remove old version from mods folder > 5. Add new version > 6. Open Game is really unreliable and would not be very nice when i would decide to do larger projects on this repo. Thats why i wanted to find early on a good setup

Avanatiker avatar Mar 09 '21 00:03 Avanatiker