kiteconnectjs icon indicating copy to clipboard operation
kiteconnectjs copied to clipboard

Published 20 hours ago • verified publisher icon zerodha

Support for TypeScript

Open rajendrasp opened this issue 3 years ago • 3 comments

Hi, Do you plan to provide type definitions anytime soon? Also there is a unofficial library written in TypeScript - https://github.com/anurag2pirad/kiteconnect-ts Would you validate it for use by us? Thanks

rajendrasp avatar Aug 28 '21 22:08 rajendrasp

Would love to have official TypeScript support.

ContraHacker avatar Aug 04 '22 16:08 ContraHacker

Yes awaiting eagerly for Typescript support.

apoorvmote avatar Aug 26 '22 05:08 apoorvmote

@ranjanrak

vividvilla avatar Aug 26 '22 05:08 vividvilla

Hey @vividvilla @ranjanrak,

I am curious as to what direction you guys want to take the project in terms of TypeScript

  • no TypeScript
  • only d.ts files
  • types in the DefinitelyTyped repo as @types/kiteconnectjs
  • full rewrite in TypeScript

@bhavyasf has made good progress in terms of a ts rewrite (#88) and I am also ready to contribute if the direction is made clear. ( I have a .d.ts PR almost ready!)

Thanks!

anurag-roy avatar Jan 09 '23 21:01 anurag-roy

Hey, I went through the discussion made in #88 and If I am correct, then now addition of types and interface is left in the codebase. Can I work on this, and also get to know If any other thing which you feel I should keep in mind before doing ?

GargDivanshu avatar May 25 '23 18:05 GargDivanshu

Hi @GargDivanshu

then now addition of types and interface is left in the codebase

This task is being actively worked on by @bhavya3024. You can track the progress of this task by following issue #96

ranjanrak avatar Jun 03 '23 04:06 ranjanrak