dotnetkiteconnect icon indicating copy to clipboard operation
dotnetkiteconnect copied to clipboard

Add Async support along with cancellation token

Open saivineeth100 opened this issue 7 months ago • 0 comments

Make Kite requests Async and cancellable as it improves responsiveness Ex :

public async Task<dynamic> Request(...,, CancellationToken token = default)
{
   //....
   string responseBody = await  response.Content.ReadAsStringAsync(token);
   //....
}

this change will completely disrupt the current API, we have a few options:

  • we could introduce a new AsyncKiteClient,
  • apply method overloading in the existing class
  • append the suffix "Async" and add new methods to the existing class.

saivineeth100 avatar Jul 03 '24 10:07 saivineeth100