svelte-toast icon indicating copy to clipboard operation
svelte-toast copied to clipboard

Add type definition for SvelteToastOptions

Open domuk-k opened this issue 1 year ago • 2 comments

The src/lib/index.js file currently lacks a type definition for SvelteToastOptions.

import { toast } from '@zerodevx/svelte-toast';
// ❌ import type { SvelteToastOptions } from '@zerodevx/svelte-toast/stores'; 
/** "/stores"  is not exposed  */ 

// 😔 export type SvelteToastOptions = Parameters<typeof toast.push>[1];

function customToast(message: string, options: SvelteToastOptions) {
   toast(message, options);
}

This change will offer a better development experience for developers using the SvelteToast library.

domuk-k avatar Sep 13 '24 06:09 domuk-k

Hey, thanks so much for the PR - moving the conversation to #107

zerodevx avatar Sep 15 '24 09:09 zerodevx

Is there any plans to release this PR ?

keytrap-x86 avatar Dec 07 '24 11:12 keytrap-x86