ice icon indicating copy to clipboard operation
ice copied to clipboard

Do not use null terminate array for property names

Open pepone opened this issue 6 years ago • 0 comments

I C# we were using null terminated arrays for the property names, that is not required.

We can use foreach or Array.Length in C# without need to check for null terminated array fixed in

https://github.com/zeroc-ice/ice/commit/5b0aeb2d874d118aff650c4ca3e20b478c3bb44a

We do the same in Java, will be best to just fix the code to not require the null entries like

https://github.com/zeroc-ice/ice/blob/5b0aeb2d874d118aff650c4ca3e20b478c3bb44a/java/src/Ice/src/main/java/com/zeroc/IceInternal/PropertyNames.java#L193

In C++ we use a custom array type, we should probably replace this with std::array

https://github.com/zeroc-ice/ice/blob/f858d073b76e0fa040382f4a3d5b3fec343f691e/cpp/src/Ice/PropertyNames.h#L38

pepone avatar Nov 09 '19 22:11 pepone