ice icon indicating copy to clipboard operation
ice copied to clipboard

`rewriteRun` Doesn't Fail Upon Parsing Error

Open InsertCreativityHere opened this issue 3 weeks ago • 0 comments

Sometimes rewrite (one of our two Java format checkers) will fail to parse a file. However, instead of failing the build (which is desirable since usually these parse failures are caused by bad formatting), the build still succeeds. This is undesirable.

We should look into whether we can change our rewrite setup to have it fail when it fails to parse.

austin@Mac controller % ./gradlew rewriteDryRun --no-parallel --no-configuration-cache       
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/9.1.0/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
Daemon will be stopped at the end of the build 

> Task :rewriteDryRun
Validating active recipes
Scanning sources in project :
Using active styles [com.zeroc.IceRewriteStyle, org.openrewrite.java.Checkstyle]
There were problems parsing some source files, run with --info to see full stack traces
There were problems parsing java/test/android/controller/src/main/java/com/zeroc/testcontroller/ControllerActivity.java
All sources parsed, running active recipes: com.zeroc.IceRewriteRecipes
Applying recipes would make no changes. No report generated.

[Incubating] Problems report is available at: file:///Users/austin/Code/personal/ice/java/test/android/controller/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/9.1.0/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 9s
5 actionable tasks: 1 executed, 4 up-to-date

InsertCreativityHere avatar Dec 10 '25 18:12 InsertCreativityHere